Fix device pixel ratio for tiff viewer#153
Merged
mvdbeek merged 2 commits intogalaxyproject:mainfrom Mar 12, 2026
Merged
Conversation
kostrykin
approved these changes
Mar 12, 2026
kostrykin
left a comment
There was a problem hiding this comment.
I tested this locally. Running the master branch locally reproduces the issue described in galaxyproject/galaxy#22073. Running this PR instead fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of findings and fix (by Copilot):
Root cause: On macOS/Retina (devicePixelRatio=2), we set the canvas backing store to width2/height2 and then divided by dpr when computing fit/center. Panzoom computed transforms from the doubled backing size, causing the image to appear 4x larger with black padding.
Fix applied (packages/tiffviewer/src/ui-manager.ts): Draw at 1:1 logical pixels and stop dpr math in fit/center. Specifically: